Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lw/static lib #812

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conversation

LukasWoodtli
Copy link
Contributor

Create a static library for Wakaama.

Server mode is enabled, if no mode (client, server or bootstrap-server)
is selected. A warning is submitted to inform the user of Wakaama about
the default. This simplifies testing and CI.
wakaama.cmake Outdated Show resolved Hide resolved
wakaama.cmake Show resolved Hide resolved
.github/workflows/build.yaml Show resolved Hide resolved
@rettichschnidi rettichschnidi self-requested a review October 2, 2024 15:29
Copy link
Contributor

@rettichschnidi rettichschnidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be beneficial to have your clarifying comments to my concerns to be stored in the Git commit messages and/or as comments in the sources.

But I am not insisting on this and therefore approving the PR.

tools/ci/run_ci.sh Outdated Show resolved Hide resolved
The CI build script now supports a flag to provide a custom build
directory.
The static library can be configured with CMake variables and then be
linked to user applications.

Wakaama became difficult to build and to maintain. Among other things,
there are defines and compiler flags that have to be set, the right set
of source files need to be selected and the correct include directories
have to be provided.

Therefore we rely on CMake and provide the users of Wakaama a static
library, which is relatively simple to build with a given set of
requested features.

This also helps with modularizing Wakaama to improve maintainability.
Copy link

sonarcloud bot commented Oct 3, 2024

@mlasch
Copy link
Contributor

mlasch commented Oct 3, 2024

It might be worthwhile to give some instructions in the readme on how to build and use the static library.

@LukasWoodtli
Copy link
Contributor Author

It might be worthwhile to give some instructions in the readme on how to build and use the static library.

I was thinking about introducing small tutorials on how to implement small applications with Wakaama. But I didn't have the resources to do that, yet.
But I will update the examples. They are already the entry point for most users of Wakaama, I think. So they will show how to use the library.

@LukasWoodtli LukasWoodtli merged commit ee0c98d into eclipse-wakaama:main Oct 3, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants